Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: curl https://bugzilla.redhat.com/show_bug.cgi?id=225671 ------- Additional Comments From paul@xxxxxxxxxxxx 2007-11-30 05:27 EST ------- A few more quickies: 1. curl no longer dlopens the LDAP libraries; instead it links to them conventionally. So the ldap_version macro definition and --with-ldap-lib/--with-lber-lib configure options are no longer needed. A buildreq of openldap-devel needs adding though. 2. How about enabling LDAPS support (--enable-ldaps)? 3. A buildreq of krb5-devel needs to be added to re-enable GSSAPI support; this used to get pulled in by openssl-devel but nss-devel doesn't do it. 4. The conditional "if pkg-config nss" seems redundant since the nss-devel buildreq will ensure that it's always true. I'd simplify things by removing the if statement entirely and replace it with: export CPPFLAGS="$(pkg-config --cflags nss) -DHAVE_PK11_CREATEGENERICOBJECT" This way, CFLAGS doesn't need to be specified in the subsequent "make" command either. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review