[Bug 2031160] Review Request: ocaml-bos - Basic OS interaction for OCaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2031160



--- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Arthur Bols from comment #3)
> Looks good! Rpmlint throws a lot of errors and warnings though. Most of them
> are dismissable, but this one I can't explain:
>   ocaml-bos.x86_64: E: shared-library-without-dependency-information
> Could you please verify this isn't a problem?

This is due to a shared object that does not depend on the C library, which can
happen when the OCaml compiler generates a shared object.  It still functions
correctly, as the OCaml runtime is able to load the shared object.  You will
see the same thing happen with some of the dependencies of ocaml-bos; for
example, run "rpmlint -i ocaml-astring" in a mock shell after building
ocaml-bos.

> - Unnecessary versioned buildrequires
>   - ocaml >= 4.08.0
>   - ocaml-fmt-devel >= 0.8.7
>   - ocaml-rresult-devel >= 0.7.0
>   - ocaml-topkg-devel >= 1.0.3
>   These are satisfied in the last 3 Fedora versions (or not available), so
> they should be unversioned.

You already know the answer to this one, so I won't bore you with it again. :-)

> Issues:
> =======
> - rpmlint errors (see belowe)
[snip]
> Rpmlint (manually)
> ------------------
> ocaml-bos-debuginfo.x86_64: W: unstripped-binary-or-object
> /usr/lib/debug/usr/lib64/ocaml/bos/bos.cmxs-0.2.1-1.fc36.x86_64.debug

These errors are normal when running rpmlint on debuginfo packages.  It is
telling you that the file full of debuginfo that it stripped out of a shared
library has not itself been stripped.  That's kind of the point. :-)

> ocaml-bos-devel.x86_64: E: static-library-without-debuginfo
> /usr/lib64/ocaml/bos/bos.a

This one is interesting.  If I add "exit 1" at the end of %install to force a
build failure, I can look at bos.a in /builddir/build/BUILDROOT.  It has
debuginfo at that point.  If I add "exit 1" to the beginning of %check, then
bos.a has been stripped.  In fact, RPM runs find-debuginfo and friends between
%install and %check.  In particular, it runs
"/usr/lib/rpm/brp-strip-static-archive /usr/bin/strip".  That must be the
culprit, because the debuginfo is gone when %check starts.  That is out of my
control.  The %build and %install scripts correctly place archives with
debuginfo into the buildroot.

> ocaml-bos-debuginfo.x86_64: W: dangling-relative-symlink
> /usr/lib/debug/.build-id/09/4035ed89dafce8469fa3486f8fe617880395cf
> ../../../.build-id/09/4035ed89dafce8469fa3486f8fe617880395cf

These errors are again a natural consequence of running rpmlint on a debuginfo
package.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2031160
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux