https://bugzilla.redhat.com/show_bug.cgi?id=2033890 Arthur Bols <arthur@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Arthur Bols <arthur@xxxxxxxx> --- > Well, technically, the guidelines say "three previous Fedora releases", which would include Fedora 33, which does *not* satisfy all those requirements. ;) Woops I was already counting Fedora 36. > It seems that this was an oversight in the original patch that added @2 scaling support to index.theme: > https://gitlab.freedesktop.org/xdg/default-icon-theme/-/issues/2 > > (issue opened in 2018 by another Fedora packager ...) That's unfortunate. :/ Maybe someone should patch the hicolor-icon-theme package? > You're right. I'll probably remove the NxN@2 icons for now and add these links: > > https://github.com/elementary/tasks/issues/321 > https://gitlab.freedesktop.org/xdg/default-icon-theme/-/issues/2 > https://bugzilla.redhat.com/show_bug.cgi?id=1537318 > https://src.fedoraproject.org/rpms/hicolor-icon-theme/pull-request/2 I replied here before there was an answer on the github issue. So apparently the @2 icons do have a use: > The icons need to be in both directories just because of the way icon themes are set up. They're SVG but GTK will load a larger icon rather than scale unless they're specified like this as HiDPI icons Removing them would diminish the experience for users with scaling a bit. You could do the effort to symlink all icons, but I don't want to force it upon you. You will be the maintainer, so I let you decide. :) Package approved! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2033890 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
