https://bugzilla.redhat.com/show_bug.cgi?id=2028702 --- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - This BuildRequires: ansible-core >= 2.11.0 would better be written without the version, BuildRequires: ansible-core since Versioned dependencies (build-time or runtime) SHOULD ONLY be used when actually necessary to guarantee that the proper version of a package is present. If a versioned dependency would be satisfied by a version present in three previous Fedora releases then a versioned dependency is not needed and a regular unversioned dependency SHOULD be used instead. and ansible-core is >= 2.11.0 in F34–F36. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies - Version 2.1.1 was released less than a day ago. Please update to the latest version. - https://src.fedoraproject.org/rpms/ansible/pull-request/19#comment-90820 explains why it’s correct for the plugin modules to have shebangs even though they are not executable (an incredibly weird situation, but I’ll take it at face value). However, there is still a problem in that the shebangs all use the unversioned Python interpreter /usr/bin/python. A nice way to fix this is to add BuildRequires: python3-devel and then, in %prep, %py3_shebang_fix . - If it is possible to run any of the tests, you should do so. If not (for example, because they require network access or administrative privileges), it would be helpful to add a comment where the %check section would be, or above the build conditional, explaining this, so it’s clear that not running the tests isn’t simply an oversight. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 47 files have unknown license. Detailed output of licensecheck in /home/reviewer/2028702-ansible-collection- community-docker/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/ansible/collections/ansible_collections/community(ansible- collection-community-general, ansible-collection-community-kubernetes, ansible-collection-community-mysql) Appropriate directory co-ownership among packages that do not have dependency relationships. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines (except as noted) [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. Version 2.1.1 is available. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Please verify whether any tests can be run. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/ansible-collections/community.docker/archive/2.0.2/community.docker-2.0.2.tar.gz : CHECKSUM(SHA256) this package : a98a6fa0b97d34e824fa72f46f421cffd82f2bdda68ea4f47aaff5b596261fd5 CHECKSUM(SHA256) upstream package : a98a6fa0b97d34e824fa72f46f421cffd82f2bdda68ea4f47aaff5b596261fd5 Requires -------- ansible-collection-community-docker (rpmlib, GLIBC filtered): (ansible >= 2.9.0 or ansible-core >= 2.11.0) Provides -------- ansible-collection-community-docker: ansible-collection(community.docker) ansible-collection-community-docker Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2028702 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: C/C++, SugarActivity, R, fonts, Perl, Ocaml, Python, PHP, Java, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 ansible-collection-community-docker.src: W: unexpanded-macro URL %{ansible_collection_url} ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/current_container_facts.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_compose.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_config.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_container.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_container_exec.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_container_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_host_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_image.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_image_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_image_load.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_login.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_network.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_network_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_node.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_node_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_plugin.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_prune.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_secret.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_stack.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_stack_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_stack_task_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm_service.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm_service_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_volume.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_volume_info.py 644 /usr/bin/python ansible-collection-community-docker.src: W: invalid-url URL %{ansible_collection_url} ansible-collection-community-docker.noarch: W: files-duplicate /usr/share/doc/ansible-collection-community-docker/CHANGELOG.rst /usr/share/ansible/collections/ansible_collections/community/docker/CHANGELOG.rst ansible-collection-community-docker.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-community-docker/COPYING /usr/share/ansible/collections/ansible_collections/community/docker/COPYING ansible-collection-community-docker.noarch: W: files-duplicate /usr/share/doc/ansible-collection-community-docker/README.md /usr/share/ansible/collections/ansible_collections/community/docker/README.md 2 packages and 0 specfiles checked; 27 errors, 5 warnings, 27 badness; has taken 0.1 s -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2028702 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
