https://bugzilla.redhat.com/show_bug.cgi?id=2010999 --- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> --- > - The explicit Requires on glib2, enchant, gtk4 and gtksourceview5 are not > necessary. They are automatically required by the dynamic link detection > (see "Requires" section below). This is necessary because these libraries have soft-ABI breakage each GNOME cycle, so it is occasionally necessary to constrict them this way. > - Package %files needs to include %dir entries for %{_datadir}/dbus-1/services, > %{_datadir}/help/C and %{_datadir}/dbus-1 or adjust the existing lines to > include the entire directory instead of the file explicitly > (i.e. %{_datadir}/dbus-1). I'll add %dir lines for these. > - Package must include a BuildRequires against gcc. > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ I'll add it in the next iteration. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2010999 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure