https://bugzilla.redhat.com/show_bug.cgi?id=2033757 --- Comment #13 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Awesome! Thanks for working with upstream on this. Since you have a PR / upstream commit that you can base your Patch0 on, you can use an "official" URL instead of your own, for example: Patch0: %{url}/pull/155.patch or Patch0: %{url}/commit/baca3e4.patch (both of those URLs are "special" GitHub URLs that redirect to a .patch file for the given PR or commit, so they also work with "spectool -g") === Note that this package also has a problem with NxN@2 scaled icons in hicolor-icon-theme, see the discussion in this bug: https://bugzilla.redhat.com/show_bug.cgi?id=2033890#c6 You can use something like "rm -r %{buildroot}/%{_datadir}/icons/hicolor/*@2/" in %install to get rid of those only-brokenly-partially-supported icon resolutions. === By the way, you don't need to generate additional changelog entries and bump Release for every change you make in the package review. It would also be fine if you reset the Release to "1%{?dist}" and remove all changelog entries in favor of one that reads "Initial import (#2033757)" when you import it to Fedora, as history of a package prior to inclusion does not matter. But if it helps you to keep track of different versions for the package review, feel free to continue bumping Release and adding changelog entries until package is accepted. === Once you address the first two points, the package is very likely ready for approval. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2033757 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
