[Bug 2037645] Review Request: Cantera - Chemical kinetics, thermodynamics, and transport tool suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2037645

Christopher Crouse <mail@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mail@xxxxxxxxx



--- Comment #2 from Christopher Crouse <mail@xxxxxxxxx> ---
Hi Mark,

Maybe I can give some pointers:

[1] The spec *Source0:* URL can be simplified: `%{url}archive/main.tar.gz`

[2] The spec %files section is very long, it may contain wildcards (*). So for
example, updating the following:

...

%{_datadir}/%{name}/data/KOH.cti
%{_datadir}/%{name}/data/KOH.xml
%{_datadir}/%{name}/data/KOH.yaml
%{_datadir}/%{name}/data/air.cti
%{_datadir}/%{name}/data/air.xml
%{_datadir}/%{name}/data/air.yaml
%{_datadir}/%{name}/data/airNASA9.cti
%{_datadir}/%{name}/data/airNASA9.xml
%{_datadir}/%{name}/data/airNASA9.yaml

%{_datadir}/%{name}/samples/cxx/combustor/combustor.cpp
%{_datadir}/%{name}/samples/cxx/custom/CMakeLists.txt

...

To use wildcards:

...

%{_datadir}/%{name}/data/*.cti
%{_datadir}/%{name}/data/*.xml
%{_datadir}/%{name}/data/*.yaml

%{_datadir}/%{name}/samples/cxx/*/*.cpp
%{_datadir}/%{name}/samples/cxx/*/*.txt

...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux