https://bugzilla.redhat.com/show_bug.cgi?id=2035671 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra | |in.net) | --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Without copying out the full re-review just yet, I think this looks good, except for the following: - The base package correctly depends on the -data subpackage, but the -data package doesn’t need to circularly depend on the base package. Also, since the -data package is noarch, it can’t have an arched dependency (no %{?_isa}). The architecture is taken from the build host, and the resulting RPM is not really noarch anymore. I recommend simply removing this line: Requires: %{name}%{?_isa} = %{version}-%{release} from %package data. At that point, it will be possible (if not terribly useful) to install the -data subpackage by itself, so you’ll need to add %license LICENSE to %files data. However, since the base package depends on the -data subpackage, you can remove the license file from the base package. - If you’re packaging mrcpp-tests, I suggest splitting it into a -tests subpackage, separate from the library. See this comment (https://bugzilla.redhat.com/show_bug.cgi?id=1955394#c12) for the rationale, which is related to multilib filtering. ---- If you like, you could avoid repeating the description with something like: %global common_description %{expand: \ The MultiResolution Computation Program Package (MRCPP) is a general purpose numerical mathematics library based on multiresolution analysis and the multiwavelet basis which provide low-scaling algorithms as well as rigorous error control in numerical computations.} %description %{common_description} […] %description devel %{common_description} This package contains the development headers and libraries. […] but you certainly do not have to. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2035671 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
