https://bugzilla.redhat.com/show_bug.cgi?id=2037363 Sanne Raymaekers <sanne.raymaekers@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |sanne.raymaekers@xxxxxxxxx Status|NEW |ASSIGNED Flags| |fedora-review- CC| |sanne.raymaekers@xxxxxxxxx --- Comment #2 from Sanne Raymaekers <sanne.raymaekers@xxxxxxxxx> --- NOTE: go2rpm -r generates the spec file with rpm autospec. Making it easier to generate the changelog and release fields. [!] duplicate READMEs: Either rename the READMEs manually in %gopkginstall; or only include the README in the project root. READMEs in subfolders don't get included in the final pkg. https://src.fedoraproject.org/rpms/golang-github-jwt/blob/rawhide/f/golang-github-jwt.spec as an example. failed review checks ==================== [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. seems %gopkgfiles doesn't seem to pickup the license? Might need an explicit %files %license LICENSE Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-cncf-xds See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/admin/fedora- review/2037363-golang-github-cncf-xds/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0". 118 files have unknown license. Detailed output of licensecheck in /home/admin/fedora- review/2037363-golang-github-cncf-xds/licensecheck.txt [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. (with note) [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/admin/fedora-review/2037363-golang- github-cncf-xds/srpm-unpacked/golang-github-cncf-xds.spec See: (this test has no URL) NOTE: Not applicable. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- golang-github-cncf-xds-devel.noarch: W: summary-not-capitalized xDS API implementation in Go golang-github-cncf-xds-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/cncf/xds/go/.goipath Source checksums ---------------- https://github.com/cncf/xds/archive/d92e9ce0af512a73a3a126b32fa4920bee12e180/xds-d92e9ce0af512a73a3a126b32fa4920bee12e180.tar.gz : CHECKSUM(SHA256) this package : a20c0fd4b6864233045ed10f1c4ba8324dfabb96706ef2485b767de426567653 CHECKSUM(SHA256) upstream package : 27be88b1ff2844885d3b2d0d579546f3a8b3f26b4871eed89082c9709e49a4bd diff -r also reports differences Requires -------- golang-github-cncf-xds-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/envoyproxy/protoc-gen-validate/validate) golang(github.com/golang/protobuf/proto) golang(github.com/golang/protobuf/ptypes/any) golang(github.com/golang/protobuf/ptypes/duration) golang(github.com/golang/protobuf/ptypes/struct) golang(github.com/golang/protobuf/ptypes/wrappers) golang(google.golang.org/grpc) golang(google.golang.org/grpc/codes) golang(google.golang.org/grpc/status) golang(google.golang.org/protobuf/reflect/protoreflect) golang(google.golang.org/protobuf/runtime/protoimpl) golang(google.golang.org/protobuf/types/descriptorpb) golang(google.golang.org/protobuf/types/known/anypb) Provides -------- golang-github-cncf-xds-devel: golang(github.com/cncf/xds/go/udpa/annotations) golang(github.com/cncf/xds/go/udpa/annotations)(commit=d92e9ce0af512a73a3a126b32fa4920bee12e180) golang(github.com/cncf/xds/go/udpa/data/orca/v1) golang(github.com/cncf/xds/go/udpa/data/orca/v1)(commit=d92e9ce0af512a73a3a126b32fa4920bee12e180) golang(github.com/cncf/xds/go/udpa/service/orca/v1) golang(github.com/cncf/xds/go/udpa/service/orca/v1)(commit=d92e9ce0af512a73a3a126b32fa4920bee12e180) golang(github.com/cncf/xds/go/udpa/type/v1) golang(github.com/cncf/xds/go/udpa/type/v1)(commit=d92e9ce0af512a73a3a126b32fa4920bee12e180) golang(github.com/cncf/xds/go/xds/annotations/v3) golang(github.com/cncf/xds/go/xds/annotations/v3)(commit=d92e9ce0af512a73a3a126b32fa4920bee12e180) golang(github.com/cncf/xds/go/xds/core/v3) golang(github.com/cncf/xds/go/xds/core/v3)(commit=d92e9ce0af512a73a3a126b32fa4920bee12e180) golang(github.com/cncf/xds/go/xds/data/orca/v3) golang(github.com/cncf/xds/go/xds/data/orca/v3)(commit=d92e9ce0af512a73a3a126b32fa4920bee12e180) golang(github.com/cncf/xds/go/xds/service/orca/v3) golang(github.com/cncf/xds/go/xds/service/orca/v3)(commit=d92e9ce0af512a73a3a126b32fa4920bee12e180) golang(github.com/cncf/xds/go/xds/type/matcher/v3) golang(github.com/cncf/xds/go/xds/type/matcher/v3)(commit=d92e9ce0af512a73a3a126b32fa4920bee12e180) golang(github.com/cncf/xds/go/xds/type/v3) golang(github.com/cncf/xds/go/xds/type/v3)(commit=d92e9ce0af512a73a3a126b32fa4920bee12e180) golang-github-cncf-xds-devel golang-ipath(github.com/cncf/xds/go) golang-ipath(github.com/cncf/xds/go)(commit=d92e9ce0af512a73a3a126b32fa4920bee12e180) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2037363 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: PHP, SugarActivity, Java, Python, fonts, Ocaml, Perl, C/C++, Haskell, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2037363 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
