https://bugzilla.redhat.com/show_bug.cgi?id=2016786 --- Comment #7 from AFOLABI, OLUYOSOLA ELIZABETH <afolabioluyosola@xxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #6) > Looks very good. A couple of issues (please see below for full explanations): > > - please correct the changelog > - please update to use the latest version > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > ===== MUST items ===== > > Generic: > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "BSD 3-Clause License". 213 files have > unknown license. Detailed output of licensecheck in > /home/asinha/2016786-python-pypesto/licensecheck.txt > [x]: Package contains no bundled libraries without FPC exception. > [!]: Changelog in prescribed format. > ^ > - Please remove "for python-pypesto" from the changelog > - Note that you can also use %autochangelog if you wish. > > [x]: Sources contain only permissible code or content. > [-]: Package contains desktop file if it is a GUI application. > [-]: Development files must be in a -devel package > [x]: Package uses nothing in %doc for runtime. > [x]: Package consistently uses macros (instead of hard-coded directory > names). > [x]: Package is named according to the Package Naming Guidelines. > [x]: Package does not generate any conflict. > [x]: Package obeys FHS, except libexecdir and /usr/target. > [-]: If the package is a rename of another package, proper Obsoletes and > Provides are present. > [x]: Requires correct, justified where necessary. > [x]: Spec file is legible and written in American English. > [-]: Package contains systemd file(s) if in need. > [x]: Package is not known to require an ExcludeArch tag. > [-]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 10240 bytes in 1 files. > [x]: Package complies to the Packaging Guidelines > [x]: Package successfully compiles and builds into binary rpms on at least > one supported primary architecture. > [x]: Package installs properly. > [x]: Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). > [x]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. > > ^ > rpm -ql -p ./python3-pypesto-0.2.7-1.fc36.noarch.rpm --licensefiles > /usr/lib/python3.10/site-packages/pypesto-0.2.7.dist-info/LICENSE > > > [x]: Package requires other packages for directories it uses. > [x]: Package must own all directories that it creates. > [x]: Package does not own files or directories owned by other packages. > [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT > [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > [x]: Macros in Summary, %description expandable at SRPM build time. > [x]: Dist tag is present. > [x]: Package does not contain duplicates in %files. > [x]: Permissions on files are set properly. > [x]: Package must not depend on deprecated() packages. > [x]: Package use %makeinstall only when make install DESTDIR=... doesn't > work. > [x]: Package is named using only allowed ASCII characters. > [x]: Package does not use a name that already exists. > [x]: Package is not relocatable. > [x]: Sources used to build the package match the upstream source, as > provided in the spec URL. > [x]: Spec file name must match the spec package %{name}, in the format > %{name}.spec. > [x]: File names are valid UTF-8. > [x]: Packages must not store files under /srv, /opt or /usr/local > > Python: > [x]: Python eggs must not download any dependencies during the build > process. > [x]: A package which is used by another package via an egg interface should > provide egg info. > [x]: Package meets the Packaging Guidelines::Python > [x]: Package contains BR: python2-devel or python3-devel > [x]: Packages MUST NOT have dependencies (either build-time or runtime) on > packages named with the unversioned python- prefix unless no properly > versioned package exists. Dependencies on Python packages instead MUST > use names beginning with python2- or python3- as appropriate. > [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files > [x]: Binary eggs must be removed in %prep > > ===== SHOULD items ===== > > Generic: > [-]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > [x]: Final provides and requires are sane (see attachments). > [x]: Package functions as described. > ^ > Package imports correctly, so this should be OK. > > [!]: Latest version is packaged. > ^ > They released 0.2.8 a few days ago, so we should use that. > > [x]: Package does not include license text files separate from upstream. > [-]: Sources are verified with gpgverify first in %prep if upstream > publishes signatures. > Note: gpgverify is not used. > [-]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. > [x]: Package should compile and build into binary rpms on all supported > architectures. > [x]: %check is present and all tests pass. > ^ > Note that the tests use some optional packages that aren't in Fedora yet, so > we use the simple import check. > > [x]: Packages should try to preserve timestamps of original installed > files. > [x]: Reviewer should test that the package builds in mock. > [x]: Buildroot is not present > [x]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. > [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file > [x]: Sources can be downloaded from URI in Source: tag > [x]: SourceX is a working URL. > [x]: Spec use %global instead of %define unless justified. > > ===== EXTRA items ===== > > Generic: > [x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). > [x]: Spec file according to URL is the same as in SRPM. > > > Rpmlint > ------- > > rpmlint *rpm ../srpm-unpacked/python-pypesto.spec > ======================================================== rpmlint session > starts ======================================================== > rpmlint: 2.1.0 > configuration: > /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml > /etc/xdg/rpmlint/fedora.toml > /etc/xdg/rpmlint/licenses.toml > /etc/xdg/rpmlint/scoring.toml > /etc/xdg/rpmlint/users-groups.toml > /etc/xdg/rpmlint/warn-on-functions.toml > checks: 31, packages: 3 > > ========================= 2 packages and 1 specfiles checked; 0 errors, 0 > warnings, 0 badness; has taken 1.7 s ========================= > > > Rpmlint (installed packages) > ---------------------------- > Cannot parse rpmlint output: > > > Source checksums > ---------------- > https://github.com/ICB-DCM/pyPESTO/archive/v0.2.7/python-pypesto-0.2.7.tar. > gz : > CHECKSUM(SHA256) this package : > c28c2235a9e3a9b536077c7b3a9b405ab71bfa6f2a11e0a7e292c57a08ef7dfc > CHECKSUM(SHA256) upstream package : > c28c2235a9e3a9b536077c7b3a9b405ab71bfa6f2a11e0a7e292c57a08ef7dfc > > > Requires > -------- > python3-pypesto (rpmlib, GLIBC filtered): > python(abi) > python3.10dist(cloudpickle) > python3.10dist(h5py) > python3.10dist(matplotlib) > python3.10dist(numpy) > python3.10dist(pandas) > python3.10dist(scipy) > python3.10dist(seaborn) > python3.10dist(tqdm) > > > > Provides > -------- > python3-pypesto: > python-pypesto > python3-pypesto > python3.10-pypesto > python3.10dist(pypesto) > python3dist(pypesto) > > > > Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 > Command line :/usr/bin/fedora-review -b 2016786 > Buildroot used: fedora-rawhide-x86_64 > Active plugins: Shell-api, Generic, Python > Disabled plugins: Perl, Ocaml, SugarActivity, R, Haskell, fonts, PHP, Java, > C/C++ > Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Thanks, I will go ahead and make the changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2016786 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
