https://bugzilla.redhat.com/show_bug.cgi?id=2036396 Christopher Crouse <mail@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@xxxxxxxxx --- Comment #1 from Christopher Crouse <mail@xxxxxxxxx> --- Hi James, Maybe I can give some suggestions: [1] I would improve the readability in the %files section, by adding in a few new lines (personal preference), for example: ... %doc CHANGES.md README.md %license LICENSE.md %{_bindir}/ocaml-mdx %{_bindir}/ocaml-mdx-test %dir %{_libdir}/ocaml/%{srcname}/ %dir %{_libdir}/ocaml/%{srcname}/test/ %dir %{_libdir}/ocaml/%{srcname}/top/ %{_libdir}/ocaml/%{srcname}/META %{_libdir}/ocaml/%{srcname}/{,*/}*.cma %{_libdir}/ocaml/%{srcname}/{,*/}*.cmi %ifarch %{ocaml_native_compiler} %{_libdir}/ocaml/%{srcname}/{,*/}*.cmxs %endif ... [2] I would move the `%ifarch %{ocaml_native_compiler}` condition in the %files devel section of the spec to the bottom. Keeping it consistent with [1], and add a few additional new lines as well, for example: ... %files devel %if %{with docs} %doc _build/default/_doc/* %endif %{_libdir}/ocaml/%{srcname}/dune-package %{_libdir}/ocaml/%{srcname}/opam %{_libdir}/ocaml/%{srcname}/{,*/}*.cmt %{_libdir}/ocaml/%{srcname}/{,*/}*.cmti %{_libdir}/ocaml/%{srcname}/{,*/}*.mli %ifarch %{ocaml_native_compiler} %{_libdir}/ocaml/%{srcname}/{,*/}*.a %{_libdir}/ocaml/%{srcname}/{,*/}*.cmx %{_libdir}/ocaml/%{srcname}/{,*/}*.cmxa %endif ... [3] I would recommend using rpmautospec for the package once it is imported. It will make maintaining the *Release* field and writing %changelog messages unnecessary in the future. Documented here, if you're interested: https://docs.pagure.org/fedora-infra.rpmautospec/index.html Note: I did run a Koji scratch rawhide build, and it failed, `DEBUG util.py:444: No matching package to install: 'ocaml-odoc-parser-devel >= 0.9.0')`. It's expected since the *depends on* is correct (https://bugzilla.redhat.com/show_bug.cgi?id=2036395) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2036396 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
