https://bugzilla.redhat.com/show_bug.cgi?id=1998755 --- Comment #5 from Wen Liang <wenliang@xxxxxxxxxx> --- Hi @js-fedora@xxxxxx, let me summarize what you need to change in the next step: 1.rpmlint detected some issues in the package. As suggested by rpmlint, you may change macOS into mac OS. You may also add changelog entry as you proposed and add the man page for binary pt2-clone in the upstream. 2. Since the package contains the GUI application, and the GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. For details on how to do that, you can take a look here, https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. 3. The spec file does not handle locales properly. This is done by using the %find_lang macro. For details, you can refer here, https://docs.fedoraproject.org/en-US/packaging-guidelines/#_handling_locale_files. In the meantime, for the item 2 and 3 above, I will follow up to propose my solution later. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1998755 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
