[Bug 2033757] Review Request: elementary-onboarding - Elementary OS getting started application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2033757



--- Comment #11 from Christopher Crouse <mail@xxxxxxxxx> ---
(In reply to Fabio Valentini from comment #9)
> (In reply to Christopher Crouse from comment #7)
> > Made some updates to the spec file. Included patch for autostart.desktop
> > file. 
> > 
> > Informed upstream about this issue on autostart.desktop file, created a
> > issue and PR, more info here:
> > https://github.com/elementary/onboarding/issues/154
> 
> This patch is probably not acceptable for upstream, because it would break
> their installer environment.
> 
> I wonder if it would be better (more generic, and also able to be pushed
> upstream) to use "OnlyShowIn=Pantheon;" insteadof "NoShowIn=Installer;"?

Updated PR and patch.

__

Spec URL:
https://download.copr.fedorainfracloud.org/results/amz/extras/fedora-rawhide-x86_64/03123155-elementary-onboarding/elementary-onboarding.spec

SRPM URL:
https://download.copr.fedorainfracloud.org/results/amz/extras/fedora-rawhide-x86_64/03123155-elementary-onboarding/elementary-onboarding-6.1.0-8.fc36.src.rpm

COPR Fedora Review:
https://download.copr.fedorainfracloud.org/results/amz/extras/fedora-rawhide-x86_64/03123155-elementary-onboarding/fedora-review/review.txt

COPR Build URL:
https://copr.fedorainfracloud.org/coprs/amz/extras/build/03123155/

Koji Mock Build URL:
https://koji.fedoraproject.org/koji/taskinfo?taskID=80797886


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2033757
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux