https://bugzilla.redhat.com/show_bug.cgi?id=2036468 --- Comment #15 from Ian McInerney <ian.s.mcinerney@xxxxxxxx> --- Looking at the build log for the x86_64 build on COPR, the Fedora flags still aren't being passed into the bundled tbb build process. For instance this is one of the build commands it is executing: [ 3%] Building CXX object src/tbb/CMakeFiles/tbb.dir/address_waiter.cpp.o cd /builddir/build/BUILD/mold-1.0.1/out/tbb/src/tbb && /usr/bin/g++ -D__TBB_BUILD -D__TBB_USE_ITT_NOTIFY -I/builddir/build/BUILD/mold-1.0.1/third-party/tbb/src/tbb/../../include -D__TBB_DYNAMIC_LOAD_ENABLED=0 -O2 -g -DNDEBUG -flifetime-dse=1 -Wall -Wextra -Wfatal-errors -mrtm -mwaitpkg -pthread -std=c++11 -MD -MT src/tbb/CMakeFiles/tbb.dir/address_waiter.cpp.o -MF CMakeFiles/tbb.dir/address_waiter.cpp.o.d -o CMakeFiles/tbb.dir/address_waiter.cpp.o -c /builddir/build/BUILD/mold-1.0.1/third-party/tbb/src/tbb/address_waiter.cpp which is missing all the -Werror=format-security and other Fedora flags. To fix this I think you will need patches 0 and 1 from the srpm I posted. The main reason this happens (even with you setting the CLFAGS/CXXFLAGS variables) is that the mold makefile will actually use -DCMAKE_CXX_FLAGS when building the bundled tbb, and that option ignores the CXXFLAGS environment variable and only uses the ones specified in the CMake command line. I am not actually sure why it isn't throwing an error about linking PIE code with non-PIE code though, because it looks like tbb is not using the -fPIE flag in its build. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2036468 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
