https://bugzilla.redhat.com/show_bug.cgi?id=2007918 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jkadlcik@redhat.c | |om) | --- Comment #5 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Thank you for pinging me, I forgot. > # Check for EPEL Python (python34, python36) > %if 0%{?python3_pkgversion} > BuildRequires: python%{python3_pkgversion}-devel > %else > BuildRequires: python3-devel I've never seen this before. Is there any motivation for it? IMHO simply BuildRequires: python3-devel is good enough. > that essentially creates and initialises the tuptime DB with its > first entry. Doing it here ensures that the permissions, etc, are > controlled, rather than being in a more random state. Can you please put that as a comment in the spec file? I think it will be useful for whoever is going to read that spec file in the future. > %systemd_user_preun tuptime.service I would expect %systemd_preun since there is %systemd_post in the %post section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2007918 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
