https://bugzilla.redhat.com/show_bug.cgi?id=2036468 --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to Christoph Erhardt from comment #4) > Thanks for the review! I've updated the .spec and .src.rpm files at the > above URLs. > > > Alternatively, you can just use "%set_build_flags" here. > `%set_build_flags` doesn't seem to work - it looks like the flags aren't > propagated to the bundled TBB. I've changed the `export`s as requested; that > doesn't cause any troubles. > > (We need the bundled TBB since Fedora's tbb package is too old and > API-incompatible. See https://bugzilla.redhat.com/show_bug.cgi?id=2036372 > for details.) > Add some information about bundled TBB, per the guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling > > If this is doing compilation, you probably want "%set_build_flags" here too before running the "make check" command. > It doesn't, so I would leave it out. > > By the way, there are two topics on which I'm not quite sure: > 1. mold defaults to being compiled with Clang; the .spec forces the compiler > to GCC. That's standard procedure according to > https://docs.fedoraproject.org/en-US/packaging-guidelines/#compiler, right? > As far as I'm aware, there are no technical reasons why this package would > work better if compiled with Clang. Yeah, seems fine to me. > 2. I had to override `strip` with `echo` to prevent the debug info from > being stripped away. This feels a bit hacky; is it considered acceptable > nonetheless? The alternative would be to patch the Makefile. That's fine, I've seen other packages do that. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2036468 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
