https://bugzilla.redhat.com/show_bug.cgi?id=2036468 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > Source0: https://github.com/rui314/mold/archive/refs/tags/v%{version}.tar.gz Please use proper SourceURL form as proscribed in the Guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags In this case, that'd be "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz" > export CFLAGS="%{optflags}" > export CXXFLAGS="%{optflags}" CFLAGS should be set to "%{build_cflags}" and CXXFLAGS should be set to "%{build_cxxflags}". Alternatively, you can just use "%set_build_flags" here. > ln -sf ../../bin/mold %{buildroot}%{_libexecdir}/mold/ld What is this? Wouldn't "ln -sr %{buildroot}%{_bindir}/mold %{buildroot}%{_libexecdir}/mold/ld" make more sense here? > %post > %{_sbindir}/update-alternatives --install %{_bindir}/ld ld %{_bindir}/ld.mold 1 This should probably only run on initial install rather than unconditionally. > %check > %make_build %{build_args} test If this is doing compilation, you probably want "%set_build_flags" here too before running the "make check" command. > %{_mandir}/man1/mold.1.gz This should be "%{_mandir}/man1/mold.1*" as you can't guarantee we won't change from gzip compression in the future. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2036468 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
