https://bugzilla.redhat.com/show_bug.cgi?id=2033886 --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > Interesting, updating the spec to the following it will build successfully, without the sed cli command: Yeah, that's because appstreamcli is less restrictive than appstream-util when validating files. In particular, appstream-util (from appstream-glib) only recognises a hard-coded list of "stock icons", and some switchboard plugs use icons that are not on that "good list". However, since now all (?) AppStream consumers in Fedora have switched away from appstream-glib to appstream, that mandatory verification will probably change, too; see: https://pagure.io/packaging-committee/issue/1053 > Should generate a patch to remove the specified stock icon from appdata In this case, using a patch instead of sed is very annoying, because the environment of the changed line includes the latest version, so that patch would need to be re-generated for every version. And since the "sed" command doesn't modify lines, but only deletes one line (and the appdata validation would fail if something went wrong), I think using the simple sed script instead of a patch is justified. > and open an issue upsteam or change to above mentioned. As I said, it's not really an issue with upstream, but rather, the stock icon doesn't appear on appstream-glib's "good list": https://github.com/hughsie/appstream-glib/issues/360 And since no application uses appstream-glib for reading AppData any longer, that issue will go away soon, regardless. > Would also recommend swopping the following two lines Good point. Done. Updated files with same URLs. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2033886 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
