https://bugzilla.redhat.com/show_bug.cgi?id=2025395 --- Comment #2 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Thank you for the review Ben, > - The installation process does not preserve timestamps. Please add the “-p” > option to “cp” in %install. Fixed > - I’m noting that /usr/share/rofi/ and /usr/share/rofi/themes/ are owned by > rofi-themes, which is a dependency of rofi, which this package depends on. > Directory ownership requirements are thus indirectly satisfied. To be sure, I added a dependency to rofi-themes, so the directory ownership isn't satisfied transitively now. Adding /usr/share/rofi/ into %files can work as well but I would rather do it once somebody has a use-case for this package without installing rofi and rofi-themes. Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/rofi-themes-base16/fedora-rawhide-x86_64/03094916-rofi-themes-base16/rofi-themes-base16.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/rofi-themes-base16/fedora-rawhide-x86_64/03094916-rofi-themes-base16/rofi-themes-base16-0.1.0-2.fc36.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2025395 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
