https://bugzilla.redhat.com/show_bug.cgi?id=2033452 Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #6 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- Looks fine, package is APPROVED one note: is there an existing bug for the s390x exclusion? If there's already one (that affects multiple mingw packages) just list it above the ExcludeArch, if not, please file one and make it block F-ExcludeArch-s390x: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages => N/A, this is mingw - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: mingw32-qt6-qtpositioning, mingw64-qt6-qtpositioning. Illegal package name: mingw32-qt6-qtpositioning, mingw64-qt6-qtpositioning. Does not provide -static: mingw32-qt6-qtpositioning, mingw64-qt6-qtpositioning. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries => N/A, likewise ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Free Documentation License v1.3", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 3", "MIT License", "*No copyright* Boost Software License 1.0", "BSD 3-Clause License", "GNU General Public License, Version 3", "*No copyright* GNU Lesser General Public License, Version 2.1", "*No copyright* [generated file]", "GNU Lesser General Public License, Version 3 GNU General Public License, Version 2", "GNU Lesser General Public License, Version 3 GNU General Public License v2.0 or later", "*No copyright* Boost Software License", "Boost Software License 1.0", "Public domain". 281 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/2033452-mingw- qt6-qtpositioning/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. => False alarm, this *is* split off from qtlocation Note: Dirs in package are owned also by: /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt6/QtPositioning(mingw64-qt6-qtlocation), /usr/x86_64-w64-mingw32/sys- root/mingw/lib/cmake/Qt6Bundled_Clip2Tri(mingw64-qt6-qtlocation), /usr/x86_64-w64-mingw32/sys- root/mingw/lib/cmake/Qt6Positioning(mingw64-qt6-qtlocation), /usr/x86_64-w64-mingw32/sys- root/mingw/lib/qt6/plugins/position(mingw64-qt6-qtlocation), /usr/i686-w64-mingw32/sys- root/mingw/include/qt6/QtPositioning(mingw32-qt6-qtlocation), /usr/i686-w64-mingw32/sys- root/mingw/lib/cmake/Qt6Bundled_Clip2Tri(mingw32-qt6-qtlocation), /usr/i686-w64-mingw32/sys- root/mingw/lib/cmake/Qt6Positioning(mingw32-qt6-qtlocation), /usr/i686-w64-mingw32/sys- root/mingw/lib/qt6/plugins/position(mingw32-qt6-qtlocation) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package => mingw, this is sort of a devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [!]: Package is not known to require an ExcludeArch tag. => ExcludeArch listed, it's fine [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-qt6-qtpositioning , mingw64-qt6-qtpositioning [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- http://download.qt.io/official_releases/qt/6.2/6.2.2/submodules/qtpositioning-everywhere-src-6.2.2.tar.xz : CHECKSUM(SHA256) this package : 26231545eae383089510b236e88bbee8a6d338c06c170b674e8f36a57a0ba09a CHECKSUM(SHA256) upstream package : 26231545eae383089510b236e88bbee8a6d338c06c170b674e8f36a57a0ba09a Requires -------- mingw32-qt6-qtpositioning (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgcc_s_dw2-1.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) mingw32(qt6core.dll) mingw32(qt6positioning.dll) mingw32-crt mingw32-filesystem mingw64-qt6-qtpositioning (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libgcc_s_seh-1.dll) mingw64(libstdc++-6.dll) mingw64(msvcrt.dll) mingw64(qt6core.dll) mingw64(qt6positioning.dll) mingw64-crt mingw64-filesystem Provides -------- mingw32-qt6-qtpositioning: mingw32(qt6positioning.dll) mingw32(qtposition_positionpoll.dll) mingw32-qt6-qtpositioning mingw64-qt6-qtpositioning: mingw64(qt6positioning.dll) mingw64(qtposition_positionpoll.dll) mingw64-qt6-qtpositioning Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2033452 -o \--uniqueext=review Buildroot used: fedora-rawhide-x86_64-review Active plugins: Shell-api, Generic Disabled plugins: PHP, Ocaml, Java, R, fonts, Haskell, SugarActivity, C/C++, Python, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2033452 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
