https://bugzilla.redhat.com/show_bug.cgi?id=2025307 --- Comment #2 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Please add a spec file comment linking the PR corresponding to Patch0: Done. > and another one linking the PR correspoding to Source1: Comment added, but Source replaced with the Patch sent upstream. > it might be easier, and save a little compiling time, to do this instead: > %configure --disable-static Thanks. Changed. > While the base package automatically depends on the -libs subpackage due to > the “hqx” executable linking “libhqx.so.1”, you should make this explicit > with a fully-versioned arch-specific dependency... Done. > As long as you aren’t supporting EPEL7, you can write... > install -m 644 -p -D %{SOURCE1} %{buildroot}%{_mandir}/man1/%{name}.1 Not needed any more, as the man page is now installed by the patched Makefile. spec: https://svgames.pl/fedora/hqx-1.2-2/hqx.spec srpm: https://svgames.pl/fedora/hqx-1.2-2/hqx-1.2-2.fc34.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=80582686 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2025307 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
