https://bugzilla.redhat.com/show_bug.cgi?id=2027139 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fedora@xxxxxxxxxx |fedora-review+ |) | Status|NEW |ASSIGNED --- Comment #9 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > export INSTALL_MAN="%{__install} -p -m 0644" Macro forms of system executables are discouraged. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros > Conflicts: nmh I guess it's rather obvious in this case, but I still think a comment saying "nmh also provides /usr/bin/pick" would be useful. Other than that, looks ok. Package approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2027139 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
