https://bugzilla.redhat.com/show_bug.cgi?id=2031721 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra | |in.net) | --- Comment #12 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Vanessa Christopher from comment #11) > Greetings @code@xxxxxxxxxxxxxxxxxx thank you for your guidelines > > I have updated the .desktop file and included an appdata file Thanks. The package is already approved, of course, but I’m happy to take a look. The AppData XML file looks basically reasonable at a glance, except for the ID, which needs to be a unique reverse-DNS style string[1] that should correspond to a domain owned by the upstream project/maintainer. This is one of the reasons it’s hard to correctly add this file downstream. You might ask upstream about an appropriate ID. The AppData XML file is required to be named to match the ID, and once there is an AppData file, the .desktop file also needs to be renamed to match. Technically, the description text is *not* available under CC0, because it’s copied from the upstream repository, which is GPLv3+—another reason I don’t usually try to add AppData files downstream-only even though the guidelines suggest trying. (I’m not interested in leaning on arguments about triviality and creative content in very short descriptive texts, and whether that might affect their copyright status.) This means you can’t technically use the upstream description in the AppData file at all. [1] https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic > I also wrote upstream about adding it > https://github.com/jwouters91/shybrid/issues/14 and I was advised to make a > contribution and open a PR but am not sure where to keep the files after > forking the project should I just place them in the root directory? There is absolutely no standard for this. I have seen at least the following, in roughly descending order of popularity, - data/ - repository root - extras/ and almost every upstream maintainer will have their own opinion. Fortunately, it’s easy to adjust a PR to upstream’s preference. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2031721 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
