https://bugzilla.redhat.com/show_bug.cgi?id=2026389 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #2) > Thanks for the review Vanessa, > > (In reply to Vanessa Christopher from comment #1) > > - python-neurotune-doc.noarch: E: files-duplicated-waste 416067 > > ^ > These are data files required for each example so they do need to be > duplicated here. You *could*, if you wanted, add BuildRequires: hardlink and now in %install: install -t '%{buildroot}%{_pkgdocdir}' -D -m 0644 README.md AUTHORS install -d '%{buildroot}%{_pkgdocdir}' cp -rp examples '%{buildroot}%{_pkgdocdir}' hardlink -v '%{buildroot}%{_pkgdocdir}/examples' (because, unfortunately, you can’t mix relative and absolute paths with %doc in the same source package[1] so you need to manually install all documentation if you manually install some documentation), and now, in %files: %doc %{_pkgdocdir} and in %files doc: %doc %{_pkgdocdir}-doc Note that I don’t recommend passing the “-c” option to hardlink in RPM packaging because we shouldn’t discard differences in mtimes. This is a little fussy, but it really does save ~400kB installed. It doesn’t stop rpmlint from yelling at you, though: now it will warn about cross-directory hardlinks, which *can* be a problem because, in the general case, the different directories could end up installed on different filesystems, and hardlinks can’t cross filesystems. In this case it’s fine, because all the hardlinked files are within one directory owned by the package and so they’re guaranteed to reside on a single filesystem. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2026389 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
