https://bugzilla.redhat.com/show_bug.cgi?id=2033828 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thanks for the review! ----- Regarding the license file—specifically, the status quo in which the license file is marked %license by %pyproject_save_files but resides in the dist-info directory rather than in /usr/share/licenses, and the question of whether it should be additionally installed in /usr/share/licenses—Miro Hrončok responded to my query on the packaging mailing list[1] agreeing that license files do not have to be installed in /usr/share/licenses, referencing an earlier thread on the same list[2] in which Jason L Tibbits III said he knew of no such requirement. Since Miro and Jason are both current FPC members, I think this is a reasonably conclusive answer to the question of whether the additional “%license …” is required. [1] https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx/thread/CQX3A7LKXYODXDSR2KZOBNM2CRNN2AYS/ [2] https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx/thread/OHNVT5S4ZPOB56KAYNCWZOC6W2WAV54C/ ----- Regarding the shared directory, there is no current dependency on this package from python-testing.postgres, so it will need to remain shared for now. This is the typical situation for Python namespace packages like this one. Once python-testing.common.database is in the distribution, I plan to offer a PR to update python-testing.postgres to a current version, which (if merged) *will* introduce the dependency. It should be possible to remove the shared directory ownership, and the shared ownership of %{python3_sitelib}/testing/__init__.py, in that PR, but that will be a change in python-testing.postgres and not in this package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2033828 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
