https://bugzilla.redhat.com/show_bug.cgi?id=2033803 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- In a quick skim of the updated spec, it looks like you’ve handled all of my suggestions. A couple of things before I do a full re-review, though: - The %pyproject_check_import “smoke test” is really intended for cases where there are no upstream tests or you can’t run them in the RPM build environment, so you could drop it now that you’re running the tests. However, it’s permissible (and sometimes advisable, in cases where the tests have exceptionally poor coverage) to do both, so you may leave this unchanged if you like. - As awkward as this is, and as fine a distinction as it is, I really think the package version should match the version in the Python metadata (version=… in setup.py) and on PyPI, which is 0.2.0, rather than the version number 0.2 from the GitHub tag and tarball name. Adjusting this would mean changing Version to 0.2.0 and replacing occurrences of %{version} with a literal “0.2”. (You could do something like “%global tarversion %(cut -d. -f-2 <<<'%{version}')” and use that if you like; personally, I would opt for less macro indirection.) Let me know what you think about the above and I’ll proceed with the full re-review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2033803 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
