https://bugzilla.redhat.com/show_bug.cgi?id=2033804 --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Maxwell G from comment #4) > Is there a reason that you're not running the tests that upstream provides? > You should do so if it's possible and practical. Thanks for noticing this. I’m not sure why I failed to to observe that tests were available in the original review. The updated submission looks fine, although I have a couple of suggestions: - It’s acceptable but not really necessary to run %pyproject_check_import now that you are running the upstream tests. The “import smoke test” is really intended for cases where upstream tests don’t exist or can’t be executed in the RPM build environment for one reason or another. - It would be best to patch out other linting and coverage tools from pytest.ini and setup.py, too: remove “--cov=flask_gravatar --cov-report=term-missing” and the dependencies on check-manifest, coverage, isort, pydocstyle, and pytest-cov (plus pytest-pep8 which you are already removing). See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2033804 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
