https://bugzilla.redhat.com/show_bug.cgi?id=2033803 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra | |in.net) | --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-flask-paranoid See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names OK: review is for unretirement - The License field says “BSD”, but it should be “MIT” - The URL should be changed to HTTPS - You should package from the GitHub tarball, Source0: %{url}/archive/v0.2/Flask-Paranoid-0.2.tar.gz since the PyPI tarball is missing both the tests and the license file. Since the license is MIT, the license text *must* be included: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text For this reason, the missing license file in the PyPI distribution is a bug and you might consider reporting it upstream. Since an upstream test suite exists, it *should* be run if possible: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_running_tests Once you have switched tarballs, this can be as simple as BuildRequires: python3dist(pytest) and then in %check: %pytest plus, in %prep: # A date format has changed somewhere: sed -r -i 's/01-Jan-1970/01 Jan 1970/' tests/test_paranoid.py - As noted in https://bugzilla.redhat.com/show_bug.cgi?id=2033804, %pyproject_check_import is simpler to use than %py3_check_import and makes it easy to test *every* importable package/module—however, you will not need to use either of these if you use the upstream test suite. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. MIT license text is required. PyPI source lacks a license file but GitHub source has it. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* MIT License", "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/reviewer/2033803-python-flask-paranoid/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines (except as mentioned) [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Suggest using the GitHub tarball to get the license file, *and* reporting the missing license file in the PyPI sdist. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. (However, upstream tests should be run instead of an import smoke test.) [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) OK (rpmautospec) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://files.pythonhosted.org/packages/source/F/Flask-Paranoid/Flask-Paranoid-0.2.0.tar.gz : CHECKSUM(SHA256) this package : a2ee9257642e0254f11578a4aa54a1a725167a641cfa0879330d477ec370c749 CHECKSUM(SHA256) upstream package : a2ee9257642e0254f11578a4aa54a1a725167a641cfa0879330d477ec370c749 Requires -------- python3-flask-paranoid (rpmlib, GLIBC filtered): python(abi) python3.10dist(flask) Provides -------- python3-flask-paranoid: python-flask-paranoid python3-flask-paranoid python3.10-flask-paranoid python3.10dist(flask-paranoid) python3dist(flask-paranoid) Diff spec file in url and in SRPM --------------------------------- --- /home/reviewer/2033803-python-flask-paranoid/srpm/python-flask-paranoid.spec 2021-12-23 14:22:54.933799154 -0500 +++ /home/reviewer/2033803-python-flask-paranoid/srpm-unpacked/python-flask-paranoid.spec 2021-11-11 07:15:30.000000000 -0500 @@ -19,5 +19,5 @@ %package -n python3-%{pkg_name} -Summary: Flask Simple user session protection +Summary: Flask Simple user session protection %description -n python3-%{pkg_name} Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2033803 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Haskell, C/C++, fonts, Ocaml, SugarActivity, R, PHP, Perl, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 python3-flask-paranoid.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.5 s -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2033803 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
