https://bugzilla.redhat.com/show_bug.cgi?id=2022153 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(code@musicinmybra | |in.net) --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Sandro Mani from comment #3) > Overall ok, only issues I see > > - License file installed when any subpackage combination is installed. > => No license file is installed below /usr/share/licenses, there is the > comment "pyproject-rpm-macros handles LICENSE.txt", but I only see the > license appearing below > > /usr/lib/python3.10/site-packages/colorcet-2.0.6.dist-info/LICENSE.txt > > Don't see anything in the packaging guidelines regarding whether is allowed, > but I believe the license must be below /usr/share/licenses? While I believe the support in pyproject-rpm-macros is intended to replace manual license file marking/installation, I don’t object to installing a duplicate license file for now. I’ve raised the issue on the packaging mailing list to ask for additional input: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx/thread/CQX3A7LKXYODXDSR2KZOBNM2CRNN2AYS/ > - rpmlint: evaluate if this needs to be addressed > python3-colorcet.noarch: W: hidden-file-or-dir > /usr/lib/python3.10/site-packages/colorcet/.version This is an unusual case. Upstream has chosen to store the canonical copy of the version number in a JSON data file named .version. It needs to be present when setup.py is called in order for the package metadata to contain the correct version number. It’s also intended to be installed, in order to load the value of __version__ at import time. This is a design shared with, and implemented in, the dependencies python-pyct and python-param. While verifying this, I found that this version of colorcet has a bug where __version__ is simply and incorrectly '1.0.0', but this is fixed in the recently-released colorcet 3.0.0 and .version is indeed required at import time. ----- I will follow up with a submission in which colorcet is updated to 3.0.0 and the additional license file is added. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2022153 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
