https://bugzilla.redhat.com/show_bug.cgi?id=2033730 --- Comment #1 from Karolina Surma <ksurma@xxxxxxxxxx> --- Hi, I consider this a blocker: %check section is entirely missing. According to the guidelines, if it's impossible to run the upstream test suite during the package build, at least a smoke import test must be run in %check. See info on %py3_check_import: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#py3_check_import %python_provide is deprecated, you can safely remove the whole line: %{?python_provide:%python_provide python3-%{srcname}}. A few non-blocking nitpicks: Take a look at the new Python Packaging Guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_distro_wide_guidelines) which promote pyproject-rpm-macros instead of the py3_build and py3_install. They can also take care of the file list in the package. The new macros are actively supported and developed. That's not a blocker, the use of the older macros is still valid. Source0: You can use a convenient macro %pypi_source which will resolve to the same url as in your specfile. >From fedora-review: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Think about not using %srcname macro, the name is unlikely to change and it's quite inconvenient to e.g. use the upstream URL when it contains macro value. I'd use the string `colored-traceback` directly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2033730 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
