https://bugzilla.redhat.com/show_bug.cgi?id=2031377 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Summary|Review Request: |Review Request: |rit-tnjoy-fonts - OpenType |rit-tn-joy-fonts - A |font for Malayalam script |traditional orthography | |font for Malayalam script CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review Suggestion: 1) When new font packaging approved in Fedora, 'fontpackages' got obsoleted by 'fonts-rpm-macros' package. Hence, drop below from SPEC file BuildRequires: fontpackages-devel Requires: fontpackages-filesystem 2) New fonts packaging guidelines need the font family name as its written in font file. For this package its "TN Joy" and the font package name will be <foundry>-<FontFamily>-fonts. Thus for this package its rit-tn-joy-fonts. 3) Submit new SPEC and SRPM links. 4) conf file path is empty in SPEC. Change %global fontconfs %{nil} to %global fontconfs meta/67-tnjoy-fonts.conf 5) Also, you need to change the "TNJoy" to "TN Joy" in 67-tnjoy-fonts.conf file. As the Font family to match is "TN Joy". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2031377 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure