https://bugzilla.redhat.com/show_bug.cgi?id=2033796 --- Comment #2 from Jarek Prokop <jprokop@xxxxxxxxxx> --- LGTM, but there are a some nits that need to be fixed before approving: * Invalid license: `python-ua-parser.src: W: invalid-license ASL2.0` * Correct format is "ASL 2.0" * E: non-executable-script /usr/lib/python3.10/site-packages/ua_parser/user_agent_parser_test.py 644 /usr/bin/python2.5 * The shebang should not be there with those file permissions. This seems like appropriate medicine: `sed -i -e '\|^#!|d' ua_parser/user_agent_parser_test.py` * Optional: It looks like a test file, which could be run in the %check section. Please fix the license and the shebang. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2033796 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
