https://bugzilla.redhat.com/show_bug.cgi?id=2031370 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx CC| |panemade@xxxxxxxxx --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review Suggestion: 1) When new font packaging approved in Fedora, 'fontpackages' got obsoleted by 'fonts-rpm-macros' package. Hence, drop below from SPEC file BuildRequires: fontpackages-devel Requires: fontpackages-filesystem 2) Change below from %global fontfamily meeranew to %global fontfamily Meera New Font Family name is "Meera New" and not "MeeraNew". Please note <SPACE> character. Thus it makes packages name as rit-meera-new-fonts. 3) You should add config file path by correcting below line %global fontconfs %{nil} 4) SPEC file shows %global fontappstreams in.org.rachana.meeranew.metainfo.xml fix this to %global fontappstreams meta/in.org.rachana.meeranew.metainfo.xml I think here upstream should actually use file name as in.org.rachana.meera-new.metainfo.xml. This is based on the way you named other font appstream file for " rit-rachana-fonts" in.org.rachana.rit-rachana.metainfo.xml where fontfamily is "RIT Rachana". Submit new package SPEC and SRPM. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2031370 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
