https://bugzilla.redhat.com/show_bug.cgi?id=1975046 --- Comment #8 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Robert-André Mauchin 🐧 from comment #7) > %generate_buildrequires > %pyproject_buildrequires > %if %{with check} > echo 'gcc-c++' > echo 'flexiblas-devel' > echo '%{py3_dist pytest}' > echo '%{py3_dist numpy}' > echo '%{py3_dist filelock}' > echo '%{py3_dist scipy}' > echo '%{py3_dist pygpu}' > echo '%{py3_dist cons}' > echo '%{py3_dist etuples}' > echo '%{py3_dist logical-unification}' > echo '%{py3_dist minikanren}' > %endif This works, but (1) most of these are in the install_requires and will be generated if you use “%pyproject_buildrequires -r”, and (2) it works perfectly well to mix “traditional” and generated BuildRequires, so “BuildRequires: gcc-c++” and so on in the usual part of the spec file would work equally well, and perhaps be a little less surprising. As you mentioned, several of these dependencies need to be packaged. I haven’t really attempted to review the existing submission, but I did also notice that aesara/d3viz is teeming with bundled, pre-minified CSS and JavaScript. It’s increasingly hard to package web assets at all given conflicts between modern build pipelines and the guidelines in https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/ and https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/; it may end up being necessary to simply try to remove this part of the library. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1975046 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
