[Bug 2033886] Review Request: switchboard-plug-onlineaccounts - Switchboard Online Accounts plug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2033886

Christopher Crouse <mail@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mail@xxxxxxxxx



--- Comment #3 from Christopher Crouse <mail@xxxxxxxxx> ---
Interesting, updating the spec to the following it will build successfully,
without the sed cli command:

___

# remove the specified stock icon from appdata (invalid in libappstream-glib)
# sed -i '/icon type="stock"/d'
%{buildroot}/%{_datadir}/metainfo/%{plug_rdnn}.appdata.xml

%check
appstreamcli validate \
     %{buildroot}/%{_datadir}/metainfo/%{plug_rdnn}.appdata.xml

___

Regardless, looks good. Should generate a patch to remove the specified stock
icon from appdata and open an issue upsteam or change to above mentioned.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2033886
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux