Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: man-pages-es https://bugzilla.redhat.com/show_bug.cgi?id=226124 ------- Additional Comments From musuruan@xxxxxxxxx 2007-11-29 05:08 EST ------- [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [!] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: f8-i386 [!] Rpmlint output: Attached to this review because it is too long. [x] Package is not relocatable. [!] Buildroot is correct [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!] License field in the package spec file matches the actual license. License type: Distributable [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. b71f701dcae827f2f5e4e848c66321fc man-pages-es-1.55.tar.bz2 5827f41f77658df17f550b7f8e831432 man-pages-es-extra-0.8a.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [!] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [!] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [x] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: f8-i386 [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files are correct. [-] File based requires are sane. === Issues === 1. Summary ends with a period. 2. "Distributable" is not a valid license: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#head-0e7556b4f56a6612e7334b142107e709b3886449 3. BuildRoot is not good: http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 4. Source files should use %{name} macro. 5. This comment is false and should be removed: # the source URL contains a tar.gz file - which has been recompressed # with bzip2 6. Extra package has a Summary entry in Spanish and not in Italian: Summary(it): Páginas de manual extras en castellano 7. Full (and wrong) path to PAQUETES and LEEME.extra files should be removed from the description of the extra package (see also issue #8). 8. These descriptions (taken from the README and LEEME files) are better than the current ones and should be used for the base package: This package contains the translation into Spanish of the English man-pages package. It is a beta release, so you can still find a lot of bugs. Contributions are welcome. For any doubt or suggestion about this release, send an e-mail to Juan Piernas Canovas <piernas at ditec.um.es>. In order to collaborate with the project, please visit http://es.tldp.org. Este archivo contiene la traducción al español del paquete man-pages en inglés. Es una versión beta, por lo que todavía puede encontrar bastantes errores. Cualquier contribución será bienvenida. Para cualquier duda o sugerencia sobre esta versión, envíe un correo a Juan Piernas Cánovas (piernas en ditec.um.es). Si desea colaborar en el proyecto, por favor, visite http://es.tldp.org. 9. These descriptions (taken from the README and LEEME.extras files) are better than the current ones and should be used for the extra package: This package contains the eighth release of the Linux extra man pages in Spanish. Note it is an alpha release, so you can find a lot of bugs. These man pages are from several packages and applications. See PAQUETES file for more information about packages. Esta paquete contiene la octava versión de páginas de manual extras en español para Linux. Note que es una versión alfa, por lo que puede encontrar bastantes errores. Estas páginas proceden de distintos paquetes y aplicaciones. Consulte el fichero PAQUETES para conocer dichos paquetes. 10. All man pages must be in UTF-8. 11. man-pages-es should Requires man, because /usr/share/man/es belongs to that package. 12. Buildarchitecture tag is obsolete. Use Buildarch. 13. Maybe it is a good idea to define a extra_name macro too (but without the extra version). 14. It should be wise to define macros at the beginning of the spec file. 15. The spec file has a mixed use of spaces and tabs. Choose one style and use it consistently. 16. You should use make install MANDIR=$RPM_BUILD_ROOT%{_mandir}/es to copy man pages to thier destination. This avoid the checks to update current installed man pages (there are no current installed man pages since they go in the buildroot). 17. You must always use macros instead of full paths: %{_mandir} instead of /usr/share/man NEEDSWORK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review