https://bugzilla.redhat.com/show_bug.cgi?id=1871171 Maxwell G <gotmax@e.email> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jsavitz@xxxxxxxxx | |m) | |needinfo?(mguma@xxxxxxxxxx) --- Comment #17 from Maxwell G <gotmax@e.email> --- Here are a couple comments: > mkdir -p %{buildroot}%_pkgdocdir > cp -r %{buildroot}%{python3_sitelib}/examples %{buildroot}%_pkgdocdir Why don't you just add the relative path with the `%doc` directive in the `%files` list? You can change `%_pkgdocdir/examples` to `%doc examples` and remove those two lines. > Version: 0.3.0 > Release: 1.a3%{?dist} Why don't you just set the version to `0.3.0.a3`? > %{?python_provide:%python_provide python3-%{pypi_name}} This line is not necessary. > Provides: python3-RPi.GPIO This line and the other virtual provides should provide a specific version. You should change `Provides: python3-RPi.GPIO` to `Provides: python3-RPi.GPIO = %{version}-%{release}`. While the srpm is named correctly, the python3 and docs subpackages are still misnamed. For the docs subpackage, you can shorten `-n python-%{pypi_name}-doc` to `doc` in the `%package`, `%description`, and `%files` directives. I would also add `%global pkgname rpi-gpio2` and replace `%{pypi_name}` with `%{pkgname}` where appropriate. I would recommend adding `Recommends: python-%{pkgname}-doc` to the `python3-%{pkgname}` subpackage, but that's up to you. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1871171 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
