https://bugzilla.redhat.com/show_bug.cgi?id=2033402 Roman Inflianskas <rominf@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(paul.wouters@aive | |n.io) --- Comment #2 from Roman Inflianskas <rominf@xxxxxxxx> --- 1. According to https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_complex_versioning_with_non_sorting_upstream_post_release_versions, your way is possible, but deprecated. The package should be named like this instead: python-folium-0.12.1.20211119.GA1-1%{?dist} 2. I don't want to include the code for testing which is complex, is a subject of change, and doesn't run automatically. Is this OK? %check # No checks here since quite a few packages for testing are not yet in Fedora # repositories; also, tests for this package depend on an internet connection. # For the instructions on running tests, please refer to: # https://github.com/python-visualization/folium/blob/main/.github/CONTRIBUTING.md#contributing-code -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2033402 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
