https://bugzilla.redhat.com/show_bug.cgi?id=2027818 Chris Rummel <crummel@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Chris Rummel <crummel@xxxxxxxxxxxxx> --- This looks good to me. There's a couple hidden files that we've seen in previous dotnet versions but no major issues. fedora-review output: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= Couple minor permissions things (under rpmlint). ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "Apache License 2.0", "MIT License", "Public domain Apache License 2.0", "MIT License Apache License 2.0", "*No copyright* Apache License 2.0", "*No copyright* GNU Lesser General Public License Apache License 2.0", "*No copyright* [generated file]", "*No copyright* GNU Lesser General Public License", "*No copyright* MIT License BSD (3 clause)", "MIT License BSD (3 clause)", "MIT License [generated file]", "GNU General Public License, Version 2", "MIT License GNU General Public License [obsolete FSF postal address (Temple Place)]", "zlib/libpng license MIT License", "MIT License BSD (2 clause)", "BSD (3 clause)", "*No copyright* MIT License GNU Lesser General Public License", "*No copyright* MIT License [generated file]", "*No copyright* Public domain MIT License", "[generated file]", "*No copyright* JSON License", "*No copyright* Public domain", "BSD (2 clause)", "zlib/libpng license", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "GNU Lesser General Public License", "*No copyright* ISC License", "BSD (3 clause) [generated file]", "ISC License", "Microsoft Public License MIT License", "SIL Open Font License 1.1", "MIT License Eclipse Public License 1.0", "BSD (4 clause) Apple Public Source License 2.0", "*No copyright* MIT License JSON License". 75807 files have unknown license. Detailed output of licensecheck in /home/chris/temp/review-dotnet6.0/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/.build-id/ea, /usr/lib64/dotnet, /etc/profile.d [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/dotnet(dotnet- build-reference-packages, dotnet-sdk-3.1-source-built-artifacts, dotnet-sdk-5.0-source-built-artifacts, dotnet-host, dotnet5.0-build- reference-packages), /usr/lib64/dotnet/source-built-artifacts(dotnet- sdk-3.1-source-built-artifacts, dotnet-sdk-5.0-source-built- artifacts), /usr/lib64/dotnet/packs(dotnet-apphost-pack-3.1, dotnet- sdk-3.1, dotnet-sdk-5.0, dotnet-targeting-pack-3.1, aspnetcore- targeting-pack-3.1, aspnetcore-targeting-pack-5.0, dotnet-targeting- pack-5.0, netstandard-targeting-pack-2.1, dotnet-apphost-pack-5.0), /usr/lib64/dotnet/sdk(dotnet-sdk-5.0, dotnet-sdk-3.1), /usr/lib64/dotnet/shared(aspnetcore-runtime-5.0, dotnet-runtime-5.0, aspnetcore-runtime-3.1, dotnet-runtime-3.1), /usr/lib64/dotnet/shared/Microsoft.NETCore.App(dotnet-runtime-5.0, dotnet-runtime-3.1), /usr/lib64/dotnet/packs/Microsoft.NETCore.App.Ref(dotnet-targeting- pack-5.0, dotnet-targeting-pack-3.1), /usr/lib64/dotnet/shared/Microsoft.AspNetCore.App(aspnetcore- runtime-5.0, aspnetcore-runtime-3.1), /usr/lib64/dotnet/packs/Microsoft.AspNetCore.App.Ref(aspnetcore- targeting-pack-3.1, aspnetcore-targeting-pack-5.0), /usr/lib64/dotnet/templates(dotnet-templates-5.0, dotnet- templates-3.1), /usr/lib64/dotnet/host/fxr(dotnet-hostfxr-3.1, dotnet- host, dotnet-hostfxr-5.0), /usr/share/bash-completion(lightdm, pipx, devscripts-checkbashisms, pcp, fd-find, flatpak, gammu, rubygem-ronn- ng, darcs, pdfgrep, just, exercism, golang-github-tdewolff-minify, nnn, tealdeer, libqmi-utils, pbuilder, tldr, chocolate-doom, hyperfine, bash-completion, chatty, fedpkg, beaker-client, policycoreutils, cowsay, zeitgeist, wlogout, kmod, skopeo, python3-catkin_tools, fx-completion, datamash, docopt, python3-trezor, vagrant, azure-cli, linode-cli, swayidle, driverctl, glib2, eg, python3-tqdm, python-django-bash-completion, ModemManager, bodhi- client, etckeeper, lmms, exa, yadifa-tools, stress-ng, swaylock, vultr-cli, cobbler, mdbtools, restic, playerctl, maven, lxc, filesystem, lxi-tools, git-delta, alacritty, bubblewrap, mtr, source- highlight, vcsh, mercurial, ripgrep, httpie, hstr, rpmspectool, smc- tools, doctl, reprepro, nitrokey-app, ldc, xca, mt-st, zypper, python3-streamlink, unar, rpmdevtools, devscripts, toolbox, skim, ethtool, clevis, dnf, awscli, falkon, breezy, zola, tio, subversion, buildah, timew, yadifa, calf, libmbim-utils, hashcat, dotnet-host, poetry, git-core, tracker, task, docker-compose, monotone, licensecheck, dconf-editor, stratis-cli, gpaste, ffsend, sway, cpu-x), /usr/share/bash-completion/completions(lightdm, GMT-common, pipx, devscripts-checkbashisms, pcp, fd-find, flatpak, gammu, rubygem-ronn- ng, darcs, pdfgrep, just, exercism, golang-github-tdewolff-minify, nnn, tealdeer, libqmi-utils, tig, pbuilder, ndctl, nbdkit-bash- completion, tldr, flameshot, libnbd-bash-completion, chocolate-doom, hyperfine, bash-completion, guestfs-tools-bash-completion, chatty, fedpkg, beaker-client, cowsay, zeitgeist, python3-pip, wlogout, kmod, skopeo, python3-catkin_tools, fx-completion, datamash, docopt, python3-trezor, vagrant, packit, azure-cli, linode-cli, swayidle, driverctl, glib2, eg, python3-tqdm, lastpass-cli, kompose, xss-lock, python-django-bash-completion, ModemManager, bodhi-client, etckeeper, lmms, exa, yadifa-tools, calibre, stress-ng, swaylock, vultr-cli, cobbler, mdbtools, restic, playerctl, maven, lxc, filesystem, lxi- tools, git-delta, alacritty, bubblewrap, mtr, source-highlight, libappstream-glib, vcsh, mercurial, firewalld, ripgrep, httpie, hstr, opensc, rpmspectool, smc-tools, doctl, libguestfs-bash-completion, firejail, coccinelle-bash-completion, reprepro, nitrokey-app, ldc, xca, mt-st, zypper, python3-streamlink, unar, rpmdevtools, devscripts, toolbox, skim, ethtool, clevis, dnf, nordugrid-arc-client, awscli, falkon, breezy, zola, tio, subversion, buildah, timew, yadifa, calf, minipro, libmbim-utils, hashcat, dotnet-host, poetry, git-core, tracker, task, docker-compose, monotone, licensecheck, dconf-editor, stratis-cli, gpaste, ffsend, sway, cpu-x) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dotnet , dotnet-host , dotnet-hostfxr-6.0 , dotnet-runtime-6.0 , aspnetcore- runtime-6.0 , dotnet-templates-6.0 , dotnet-sdk-6.0 , dotnet-apphost- pack-6.0 , dotnet-targeting-pack-6.0 , aspnetcore-targeting-pack-6.0 , netstandard-targeting-pack-2.1 , dotnet-sdk-6.0-source-built-artifacts [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _lto_cflags %{nil} [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: dotnet-6.0.100-1.fc36~bootstrap.x86_64.rpm dotnet-host-6.0.0-1.fc36~bootstrap.x86_64.rpm dotnet-hostfxr-6.0-6.0.0-1.fc36~bootstrap.x86_64.rpm dotnet-runtime-6.0-6.0.0-1.fc36~bootstrap.x86_64.rpm aspnetcore-runtime-6.0-6.0.0-1.fc36~bootstrap.x86_64.rpm dotnet-templates-6.0-6.0.100-1.fc36~bootstrap.x86_64.rpm dotnet-sdk-6.0-6.0.100-1.fc36~bootstrap.x86_64.rpm dotnet-apphost-pack-6.0-6.0.0-1.fc36~bootstrap.x86_64.rpm dotnet-targeting-pack-6.0-6.0.0-1.fc36~bootstrap.x86_64.rpm aspnetcore-targeting-pack-6.0-6.0.0-1.fc36~bootstrap.x86_64.rpm netstandard-targeting-pack-2.1-6.0.100-1.fc36~bootstrap.x86_64.rpm dotnet-sdk-6.0-source-built-artifacts-6.0.100-1.fc36~bootstrap.x86_64.rpm dotnet6.0-debuginfo-6.0.100-1.fc36~bootstrap.x86_64.rpm dotnet6.0-debugsource-6.0.100-1.fc36~bootstrap.x86_64.rpm dotnet6.0-6.0.100-1.fc36~bootstrap.src.rpm aspnetcore-runtime-6.0.x86_64: W: hidden-file-or-dir /usr/lib64/dotnet/shared/Microsoft.AspNetCore.App/6.0.0/.version dotnet-sdk-6.0.x86_64: W: hidden-file-or-dir /usr/lib64/dotnet/sdk/6.0.100/.toolsetversion dotnet-sdk-6.0.x86_64: W: hidden-file-or-dir /usr/lib64/dotnet/sdk/6.0.100/.version aspnetcore-targeting-pack-6.0.x86_64: E: description-line-too-long C that allows developers to compile against and target Microsoft.AspNetCore.App 6.0 dotnet6.0.src: W: strange-permission check-debug-symbols.py 775 Rpmlint (debuginfo) ------------------- Checking: dotnet6.0-debuginfo-6.0.100-1.fc36~bootstrap.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Unversioned so-files -------------------- dotnet-hostfxr-6.0: /usr/lib64/dotnet/host/fxr/6.0.0/libhostfxr.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libSystem.Globalization.Native.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libSystem.IO.Compression.Native.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libSystem.Native.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libSystem.Net.Security.Native.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libSystem.Security.Cryptography.Native.OpenSsl.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libclrjit.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libcoreclr.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libcoreclrtraceptprovider.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libdbgshim.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libhostpolicy.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libmscordaccore.so dotnet-runtime-6.0: /usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.0/libmscordbi.so dotnet-apphost-pack-6.0: /usr/lib64/dotnet/packs/Microsoft.NETCore.App.Host.fedora.36-x64/6.0.0/runtimes/fedora.36-x64/native/libnethost.so Requires -------- dotnet (rpmlib, GLIBC filtered): dotnet-sdk-6.0(x86-64) dotnet-host (rpmlib, GLIBC filtered): config(dotnet-host) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) dotnet-hostfxr-6.0 (rpmlib, GLIBC filtered): dotnet-host(x86-64) ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) rtld(GNU_HASH) dotnet-runtime-6.0 (rpmlib, GLIBC filtered): dotnet-hostfxr-6.0(x86-64) ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libicu(x86-64) liblttng-ust.so.1()(64bit) libm.so.6()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libunwind-x86_64.so.8()(64bit) libunwind.so.8()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) aspnetcore-runtime-6.0 (rpmlib, GLIBC filtered): dotnet-runtime-6.0(x86-64) dotnet-templates-6.0 (rpmlib, GLIBC filtered): dotnet-host(x86-64) dotnet-sdk-6.0 (rpmlib, GLIBC filtered): aspnetcore-runtime-6.0(x86-64) aspnetcore-targeting-pack-6.0(x86-64) dotnet-apphost-pack-6.0(x86-64) dotnet-runtime-6.0(x86-64) dotnet-targeting-pack-6.0(x86-64) dotnet-templates-6.0(x86-64) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) netstandard-targeting-pack-2.1(x86-64) rtld(GNU_HASH) dotnet-apphost-pack-6.0 (rpmlib, GLIBC filtered): dotnet-host(x86-64) ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libunwind-x86_64.so.8()(64bit) libunwind.so.8()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) dotnet-targeting-pack-6.0 (rpmlib, GLIBC filtered): dotnet-host(x86-64) aspnetcore-targeting-pack-6.0 (rpmlib, GLIBC filtered): dotnet-host(x86-64) netstandard-targeting-pack-2.1 (rpmlib, GLIBC filtered): dotnet-host(x86-64) dotnet-sdk-6.0-source-built-artifacts (rpmlib, GLIBC filtered): dotnet6.0-debuginfo (rpmlib, GLIBC filtered): dotnet6.0-debugsource (rpmlib, GLIBC filtered): Provides -------- dotnet: dotnet dotnet(x86-64) dotnet-host: config(dotnet-host) dotnet-host dotnet-host(x86-64) dotnet-hostfxr-6.0: dotnet-hostfxr-6.0 dotnet-hostfxr-6.0(x86-64) dotnet-runtime-6.0: dotnet-runtime-6.0 dotnet-runtime-6.0(x86-64) libSystem.Globalization.Native.so()(64bit) libSystem.IO.Compression.Native.so()(64bit) libSystem.IO.Compression.Native.so(V1.0)(64bit) libSystem.Native.so()(64bit) libSystem.Net.Security.Native.so()(64bit) libSystem.Security.Cryptography.Native.OpenSsl.so()(64bit) aspnetcore-runtime-6.0: aspnetcore-runtime-6.0 aspnetcore-runtime-6.0(x86-64) dotnet-templates-6.0: dotnet-templates-6.0 dotnet-templates-6.0(x86-64) dotnet-sdk-6.0: bundled(js-jquery) dotnet-sdk-6.0 dotnet-sdk-6.0(x86-64) dotnet-apphost-pack-6.0: dotnet-apphost-pack-6.0 dotnet-apphost-pack-6.0(x86-64) libnethost.so()(64bit) dotnet-targeting-pack-6.0: dotnet-targeting-pack-6.0 dotnet-targeting-pack-6.0(x86-64) aspnetcore-targeting-pack-6.0: aspnetcore-targeting-pack-6.0 aspnetcore-targeting-pack-6.0(x86-64) netstandard-targeting-pack-2.1: netstandard-targeting-pack-2.1 netstandard-targeting-pack-2.1(x86-64) dotnet-sdk-6.0-source-built-artifacts: dotnet-sdk-6.0-source-built-artifacts dotnet-sdk-6.0-source-built-artifacts(x86-64) dotnet6.0-debuginfo: dotnet6.0-debuginfo dotnet6.0-debuginfo(x86-64) dotnet6.0-debugsource: dotnet6.0-debugsource dotnet6.0-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -n dotnet6.0 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Ocaml, Perl, Python, R, Haskell, Java, PHP, SugarActivity, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2027818 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
