Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: goocanvasmm - C++ interface for goocanvas https://bugzilla.redhat.com/show_bug.cgi?id=402541 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-11-29 01:06 EST ------- I can't see any problem like dot errors in new mock build Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 2d1d634184a7564a913fd5b80bda4b5d goocanvasmm-0.4.0.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + goocanvasmm-1.0.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package goocanvasmm-0.4.0-2.fc9 -> Provides: libgoocanvasmm-0.1.so.1 Requires: libatk-1.0.so.0 libatkmm-1.6.so.1 libc.so.6 libc.so.6(GLIBC_2.1.3) libcairo.so.2 libcairomm-1.0.so.1 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgdkmm-2.4.so.1 libglib-2.0.so.0 libglibmm-2.4.so.1 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgoocanvas.so.3 libgoocanvasmm-0.1.so.1 libgtk-x11-2.0.so.0 libgtkmm-2.4.so.1 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangomm-1.4.so.1 libsigc-2.0.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH) + Package goocanvasmm-devel-0.4.0-2.fc9 -> Requires: goocanvas-devel goocanvasmm = 0.4.0-2.fc9 gtkmm24-devel libgoocanvasmm-0.1.so.1 pkgconfig + Not a GUI App. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review