https://bugzilla.redhat.com/show_bug.cgi?id=2013814 --- Comment #15 from Brian Lane <bcl@xxxxxxxxxx> --- No, you still haven't fixed the following issues from comment #1 * Use the %{version} macro when referring to the version number in the spec. eg. the Source0 line, this makes it easier to update to the next version, you just need to edit the number in one place. * In %prep use the %autosetup macro instead of %setup, this will apply any PatchXXX files automatically * A number of the files are ending up in both libxo and libxo-devel: - include files should all be in -devel only - the library documentation in man3 should all be in -devel only - the .a and .pc files should only be in -devel - you don't need to have the man3 directory name in the %file section, the manpage directories are already present, just refer to the files or a suitable wildcard. * The .so files should not be wildcarded, this can lead to unexpected problems when the version number changes. Instead refer to them as their full filename, or eg. libenc*so.0 libenc*so.0.0.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2013814 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
