https://bugzilla.redhat.com/show_bug.cgi?id=2030668 François Kooman <fkooman@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from François Kooman <fkooman@xxxxxxxxx> --- Except the tiny nit for BuildRequires in previous comment, all looks good! Package: APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 12 files have unknown license. Detailed output of licensecheck in /home/fedora/2030668-php-zumba-json- serializer/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. PHP: [x]: Run phpci static analyze on all php files. Note: Data Source Analysed Directories 4 Files 8 Errors 0 Extensions Analysis Extension REF EXT min/Max PHP min/Max core core 4.3.0 4.3.0 date date 5.2.0 5.2.0 json json 1.2.1 5.6.6RC1 mbstring mbstring 4.4.3 4.4.3 pcre pcre 4.0.0 4.0.0 reflection reflection 5.4.0 5.4.0 spl spl 5.3.0 5.3.0 standard standard 4.0.7 5.0.0 Total [8] 5.6.6RC1 Namespaces Analysis Namespace REF EXT min/Max PHP min/Max Zumba\JsonSerializer core 5.4.0 5.6.6RC1 Zumba\JsonSerializer\Exception user 5.3.0 Zumba\JsonSerializer\Test standard 5.3.0 5.5.0 Zumba\JsonSerializer\Test\SupportClasses standard 4.0.0 5.3.0 Total [4] 5.6.6RC1 No interface found No trait found Classes Analysis Class REF EXT min/Max PHP min/Max DateTime date 5.2.0 5.2.0 DateTimeZone date 5.2.0 5.2.0 InvalidArgumentException spl 5.1.0 5.1.0 ReflectionClass reflection 5.0.0 5.0.0 ReflectionProperty reflection 5.0.0 5.0.0 SplDoublyLinkedList spl 5.3.0 5.3.0 SplObjectStorage spl 5.1.0 5.1.0 CU SuperClosure\Serializer user 0.1.0 5.3.0 U SuperClosure\SerializerInterface user 5.3.0 U Zumba\JsonSerializer\Exception\JsonSerializerException user 5.3.0 Zumba\JsonSerializer\JsonSerializer core 5.4.0 5.6.6RC1 Zumba\JsonSerializer\Test\JsonSerializerTest standard 5.3.0 5.5.0 U Zumba\JsonSerializer\Test\SupportClasses\AllVisibilities user 5.3.0 U Zumba\JsonSerializer\Test\SupportClasses\EmptyClass user 5.3.0 U Zumba\JsonSerializer\Test\SupportClasses\MagicClass user 5.3.0 U Zumba\JsonSerializer\Test\SupportClasses\MyType user 5.3.0 Zumba\JsonSerializer\Test\SupportClasses\MyTypeSerializer standard 4.0.0 5.3.0 stdClass core 4.0.0 4.0.0 Total [18] 5.6.6RC1 No generator found Functions Analysis Function REF EXT min/Max PHP min/Max Zumba\JsonSerializer\Test\JsonSerializerTest\testSerializationOfClosure\closure-316-318 user 5.3.0 Zumba\JsonSerializer\Test\JsonSerializerTest\testSerializeClosureWithoutSerializer\closure-124-126 user 5.3.0 Zumba\JsonSerializer\Test\JsonSerializerTest\testUnserializeOfClosureWithoutSerializer\closure-345-347 user 5.3.0 array_key_exists standard 4.0.7 4.0.7 array_keys standard 4.0.0 4.0.0 array_map standard 4.0.6 4.0.6 array_merge standard 4.0.0 4.0.0 array_unique standard 4.0.1 4.0.1 chr standard 4.0.0 4.0.0 class_exists core 4.0.0 4.0.0 explode standard 4.0.0 4.0.0 fopen standard 4.0.0 4.0.0 get_object_vars core 4.0.0 4.0.0 in_array standard 4.0.0 4.0.0 is_array standard 4.0.0 4.0.0 is_resource standard 4.0.0 4.0.0 is_scalar standard 4.0.5 4.0.5 is_string standard 4.0.0 4.0.0 json_decode json 1.2.1 5.2.0 json_encode json 1.2.1 5.3.0 json_last_error json 1.2.1 5.3.0 mb_check_encoding mbstring 4.4.3 4.4.3 mb_convert_encoding mbstring 4.0.6 4.0.6 mb_strpos mbstring 4.0.6 4.0.6 method_exists core 4.0.0 4.0.0 preg_replace pcre 4.0.0 4.0.0 serialize standard 4.0.0 4.0.0 setlocale standard 4.0.0 4.0.0 strlen core 4.0.0 4.0.0 substr standard 4.0.0 4.0.0 unserialize standard 4.0.0 4.0.0 version_compare standard 4.0.7 4.0.7 Total [32] 5.3.0 Constants Analysis Constant REF EXT min/Max PHP min/Max JSON_ERROR_NONE json 1.2.1 5.3.0 JSON_ERROR_UTF8 json 1.2.1 5.3.3 JSON_PRESERVE_ZERO_FRACTION json 1.2.1 5.6.6RC1 JSON_UNESCAPED_UNICODE json 1.2.1 5.4.0 LC_NUMERIC standard 4.0.0 4.0.0 NAN standard 4.0.0 4.0.0 PHP_VERSION core 4.0.0 4.0.0 Zumba\JsonSerializer\JsonSerializer\CLASS_IDENTIFIER_KEY user 4.0.0 Zumba\JsonSerializer\JsonSerializer\CLOSURE_IDENTIFIER_KEY user 4.0.0 Zumba\JsonSerializer\JsonSerializer\FLOAT_ADAPTER user 4.0.0 Zumba\JsonSerializer\JsonSerializer\KEY_UTF8ENCODED user 4.0.0 Zumba\JsonSerializer\JsonSerializer\SCALAR_IDENTIFIER_KEY user 4.0.0 Zumba\JsonSerializer\JsonSerializer\UNDECLARED_PROPERTY_MODE_EXCEPTION user 4.0.0 Zumba\JsonSerializer\JsonSerializer\UNDECLARED_PROPERTY_MODE_IGNORE user 4.0.0 Zumba\JsonSerializer\JsonSerializer\UNDECLARED_PROPERTY_MODE_SET user 4.0.0 Zumba\JsonSerializer\JsonSerializer\UTF8ENCODED_IDENTIFIER_KEY user 4.0.0 Zumba\JsonSerializer\JsonSerializer\VALUE_UTF8ENCODED user 4.0.0 __FILE__ core 4.0.0 4.0.0 __FUNCTION__ core 4.3.0 4.3.0 false core 4.0.0 4.0.0 null core 4.0.0 4.0.0 true core 4.0.0 4.0.0 Total [22] 5.6.6RC1 Conditions Analysis Condition REF EXT min/Max PHP min/Max class_exists(SuperClosure\Serializer) user 0.1.0 4.0.0 Total [1] 4.0.0 Requires PHP 5.6.6RC1 (min) Profile results are being logged as JSON format to /home/fedora/2030668-php-zumba-json- serializer/phpci.log phpCompatInfo version 5.5.3 DB version 3.14.0 static analyze results in /home/fedora/2030668-php-zumba-json- serializer/phpci.log Rpmlint ------- Checking: php-zumba-json-serializer-3.0.1-1.fc36.noarch.rpm php-zumba-json-serializer-3.0.1-1.fc36.src.rpm php-zumba-json-serializer.noarch: W: spelling-error %description -l en_US unserialize -> serialize, universalize php-zumba-json-serializer.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-zumba-json-serializer.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology php-zumba-json-serializer.src: W: spelling-error %description -l en_US unserialize -> serialize, universalize php-zumba-json-serializer.src: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-zumba-json-serializer.src: W: spelling-error %description -l en_US usr -> use, us, user php-zumba-json-serializer.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/zumba/json-serializer/archive/d91d5a22bbbacbb1d6ad23302137a90e9a7dafd5/php-zumba-json-serializer-3.0.1-d91d5a2.tar.gz : CHECKSUM(SHA256) this package : 097cbd5c699434415ff3d1b5c251e80e405d688d3bdfdbf14ddc81ed757d1068 CHECKSUM(SHA256) upstream package : 097cbd5c699434415ff3d1b5c251e80e405d688d3bdfdbf14ddc81ed757d1068 Requires -------- php-zumba-json-serializer (rpmlib, GLIBC filtered): php(language) php-composer(fedora/autoloader) php-json php-mbstring php-pcre php-reflection php-spl Provides -------- php-zumba-json-serializer: php-composer(zumba/json-serializer) php-zumba-json-serializer Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2030668 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: R, Python, SugarActivity, Java, Ocaml, Perl, C/C++, fonts, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2030668 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
