Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: joesnmp - Java SNMP class library https://bugzilla.redhat.com/show_bug.cgi?id=252101 konrad@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |konrad@xxxxxxxxxx ------- Additional Comments From konrad@xxxxxxxxxx 2007-11-28 20:25 EST ------- 1) rpmlint -i says: joesnmp.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 53) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. 2) License should be LGPLv2+ (not just LGPL) as per the source and LICENSE.txt. 3) LICENSE.txt is shipped with the source zip, but doesn't contain the full LGPL, I am not sure whether or not it should be included in %doc. I think you are OK here. 4) Source0 should be a URL of the package on sf.net. (Did you mean http://downloads.sourceforge.net/joesnmp/joesnmp-0.3.4.zip ?) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review