https://bugzilla.redhat.com/show_bug.cgi?id=2026389 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanessaigwe1@xxxxxxxxx --- Comment #1 from Vanessa Christopher <vanessaigwe1@xxxxxxxxx> --- This is a pre-review :) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Dist tag is present. Lint has 1 error - python-neurotune-doc.noarch: E: files-duplicated-waste 416067 ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 74 files have unknown license. Detailed output of licensecheck in /home/vanessa/Desktop/reviews/2026389-python- neurotune/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-neurotune [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- ============================== rpmlint session starts ============================= rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 python-neurotune.spec:85: W: macro-in-%changelog %autochangelog python-neurotune-doc.noarch: E: files-duplicated-waste 416067 python-neurotune-doc.noarch: W: files-duplicate /usr/share/doc/python-neurotune-doc/examples/example_2/100pA_1.csv /usr/share/doc/python-neurotune-doc/examples/example_1/100pA_1.csv python-neurotune-doc.noarch: W: files-duplicate /usr/share/doc/python-neurotune-doc/examples/example_2/Kv_3_erisir_99.mod /usr/share/doc/python-neurotune-doc/examples/example_1/Kv_3_erisir_99.mod python-neurotune-doc.noarch: W: files-duplicate /usr/share/doc/python-neurotune-doc/examples/example_2/kv_1.mod /usr/share/doc/python-neurotune-doc/examples/example_1/kv_1.mod python-neurotune-doc.noarch: W: files-duplicate /usr/share/doc/python-neurotune-doc/examples/example_2/na.mod /usr/share/doc/python-neurotune-doc/examples/example_1/na.mod python3-neurotune.noarch: W: description-shorter-than-summary 2 packages and 1 specfiles checked; 1 errors, 6 warnings, 1 badness; has taken 1.3 s Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/NeuralEnsemble/neurotune/archive/a17f0fd192b20e29b032826b6c54568e0bbef445/neurotune-a17f0fd192b20e29b032826b6c54568e0bbef445.tar.gz : CHECKSUM(SHA256) this package : 4e148543930d3429aa48a3a256ba37b5a0d4502cea37657a50119092ba33988b CHECKSUM(SHA256) upstream package : 4e148543930d3429aa48a3a256ba37b5a0d4502cea37657a50119092ba33988b Requires -------- python3-neurotune (rpmlib, GLIBC filtered): python(abi) python-neurotune-doc (rpmlib, GLIBC filtered): Provides -------- python3-neurotune: python-neurotune python3-neurotune python3.10-neurotune python3.10dist(neurotune) python3dist(neurotune) python-neurotune-doc: python-neurotune-doc Diff spec file in url and in SRPM --------------------------------- --- /home/vanessa/Desktop/reviews/2026389-python-neurotune/srpm/python-neurotune.spec 2021-12-12 15:54:07.061259346 -0500 +++ /home/vanessa/Desktop/reviews/2026389-python-neurotune/srpm-unpacked/python-neurotune.spec 2021-11-24 09:21:31.000000000 -0500 @@ -1,2 +1,18 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.2.5) +%define autorelease(e:s:pb:) %{?-p:0.}%{lua: + release_number = 4; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{?dist} +## END: Set by rpmautospec + +# Enabled by default +# If the package needs to download data for the test which cannot be done in +# koji, these can be disabled in koji by using `bcond_with` instead, but the +# tests must be validated in mock with network enabled like so: +# mock -r fedora-rawhide-x86_64 rebuild <srpm> --enable-network --rpmbuild-opts="--with tests" +%bcond_without tests + %global forgeurl https://github.com/NeuralEnsemble/neurotune/ @@ -4,11 +20,5 @@ %global _description %{expand: -This package provides Neurotune, a package for optimizing electical models of -excitable cells. - -This package was originally developed by Mike Vella. This has been updated by -Padraig Gleeson and others (and moved to NeuralEnsemble) to continue -development of pyelectro and Neurotune for use in OpenWorm, Open Source Brain -and other projects.} +Add a description here.} Name: python-neurotune @@ -71,8 +81,9 @@ %check +%if %{with tests} rm -rf neurotune export PYTHONPATH="%{buildroot}%{python3_sitearch}:%{buildroot}%{python3_sitelib}" ./test.sh - +%endif %files -n python3-neurotune -f %{pyproject_files} %doc README.md AUTHORS @@ -83,3 +94,13 @@ %changelog -%autochangelog +* Wed Nov 24 2021 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@xxxxxxxxx> 0.2.3-0.4 +- Uncommitted changes + +* Fri Nov 19 2021 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@xxxxxxxxx> 0.2.3-0.3 +- fix: correct autorelease usage + +* Fri Nov 19 2021 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@xxxxxxxxx> 0.2.3-0.2 +- WIP: enable tests + +* Fri Nov 19 2021 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@xxxxxxxxx> 0.2.3-1 +- init spec Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2026389 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: Java, Ocaml, Haskell, Perl, SugarActivity, PHP, fonts, C/C++, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2026389 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
