[Bug 2028270] Review Request: termcolor - Header-only C++ library for printing colored messages to the terminal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2028270



--- Comment #11 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Could you please adjust the path to the test executable?

Change:

  %{_builddir}/%{name}-%{version}/redhat-linux-build/test_termcolor

to

  %{_vpath_builddir}/test_termcolor

See:

https://docs.fedoraproject.org/en-US/packaging-guidelines/vpath/
https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/#_available_macros

The definition of _vpath_builddir has changed in the past and may well change
again.

----

> I think elfio's noarch works fine because it's installing cmake's definitions in /usr/share/elfio/cmake/ that is architecture agnostic.

This came up on the packaging mailing list in the thread I linked in a previous
comment. Independent of packaging policy, you’re certainly correct that
installing anything in %{_libdir} precludes using noarch for the (sub)package
in question.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2028270
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux