https://bugzilla.redhat.com/show_bug.cgi?id=2028270 --- Comment #8 from Petr Menšík <pemensik@xxxxxxxxxx> --- I would say [!]: %check is present and all tests pass. There is a test which should be enabled and built. At least it ensures the code compiles. I admit those nice colors would not be verified similar way to human, but it would ensure at least minimal test. But that is only SHOULD, not required. Maybe the test could be part of base package. I think testing different terminal capabilities might be useful, it can display common colors in a compact way. I have missed unowned %{_libdir}/cmake though, that is mandatory change. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2028270 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
