Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trousers - The open-source TCG software stack https://bugzilla.redhat.com/show_bug.cgi?id=323441 ------- Additional Comments From yoder1@xxxxxxxxxx 2007-11-28 12:01 EST ------- Hi Mamoru, > - Please consider to use %?dist tag. > http://fedoraproject.org/wiki/Packaging/DistTag Thanks, added this to the release. > - Source must be given with full URL. > http://fedoraproject.org/wiki/Packaging/SourceURL > Please check the section "Sourceforge.net" done > - "Requires: gtk+, openssl" is not needed. > * rpmbuild checks dependencies for libraries when rebuild is > done and then adds the dependencies to Requires automatically. Ok, deleted. > - "Requires(post/postun): ldconfig" is not needed. In response to other comments, I'll keep this... > - "--prefix=/usr --libdir=%_libdir" is not needed for %configure. > (You can check what %configure actually does by > $ rpm --eval %configure). Cool, thanks, very handy to know. > - Please remove unneeded > [ "${RPM_BUILD_ROOT}" != "/" ] && [ -d ${RPM_BUILD_ROOT} ] && done > - You should not turn chkconfig service on by default. Ok, the chkconfig stuff was added on instructions from others. Can we get consensus? > - Please use "-p" option for "cp" or "install" commands to > keep timestamps on installed files. done > - Now we recommend %defattr(-,root,root,-) done. What does the second '-' do? (I didn't see this int he RPM howto). > - This package seems to need tss user/group. Please refer to > http://fedoraproject.org/wiki/Packaging/UsersAndGroups Thanks, updated. > - If you want to package static archives (for this package, > %_libdir/libtddl.a), create -static subpackage and > move all static archives to -static subpackage. done > - Check what package owns %{_includedir}/tss/ and > %_includedir/trousers directories. I'm not sure I understand here, can you explain? THanks, Kent -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review