https://bugzilla.redhat.com/show_bug.cgi?id=1954478 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra | |in.net) | |needinfo?(code@musicinmybra | |in.net) | --- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- > 1. So does this mean that the line would look like this %files -f INSTALLED_FILES -n python3-%{unmangled_name} or %files just -n python3-%{unmangled_name} ? Yes, just: %files -n python3-%{unmangled_name} Although you can choose (for now) whether to package under the “new” Python guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/) using pyproject-rpm-macros, or the “old” ones (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/). If you use the new guidelines, which I would recommend, you’ll end up with: %files -n python3-%{unmangled_name} -f %{pyproject_files} > 2. "It also looks like you submitted an email address rather than a Fedora Account System username. An FAS username is required for a successful review to be processed.", I did create this after logging in with FAS, am I supposed to do anything different ? I’m referring to the text in the description for this issue: “Fedora Account System Username: acrandom@xxxxx” That needs to be your FAS username, not an email. For example, I’m https://accounts.fedoraproject.org/user/music/, so I would put “music” there. > 3. "Note that this means you will have to submit a new review ticket with the correct name." So this basically means that I will have to close this one and create a new one, correct ? I think so. It might be possible to change the issue title to contain the correct package name (“python-proton-client”), and put the correct FAS username in a “Fedora Account System Username: WHOMEVER” line in a new comment. You would learn if that worked after the package was approved and you tried to request a dist-git repository. Worst case, you would have to close this bug and re-open a new one then, and ask your reviewer to re-approve using the new issue. That happens sometimes. Still, if it were me, I would go ahead and close this issue and create a new one instead of trying to fix this one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1954478 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
