https://bugzilla.redhat.com/show_bug.cgi?id=2028895 --- Comment #4 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- Spec URL: https://alebastr.fedorapeople.org/review/tree-sitter-cli/rust-tree-sitter.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/rust-tree-sitter-cli/fedora-rawhide-x86_64/03012110-rust-tree-sitter/rust-tree-sitter-0.20.1-3.fc36.src.rpm Copr Build: https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/build/3012110/ Exploded view with patches: https://copr-dist-git.fedorainfracloud.org/cgit/alebastr/rust-tree-sitter-cli/rust-tree-sitter.git/tree/?id=459c0decd4555b1153bf1f791a720cf20d8af48a Changes: - Added the `generate-bindings` feature and a patch to make it default (upstream PR is sent[1], waiting for a feedback). Invoking /usr/bin/bindgen doesn't really work, as it will create the bindings for a build machine arch, and our rust library packages are all noarch. - Added %%set_build_flags to verify that the C code compiles with recommended flags. - Added bundled(tree-sitter) to the `devel` subpackage. I run upstream unit tests on all our supported arches (except of s390x; LLVM keeps crashing in the copr chroot), and everything passed. *** > Generated sources must be regenerated at build time. Actually, no. The Guidelines only *suggest* that[1]. We have a stricter policy for Python, but not for Rust. [1]: https://github.com/tree-sitter/tree-sitter/pull/1524 [2]: https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#_pregenerated_code -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2028895 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
