https://bugzilla.redhat.com/show_bug.cgi?id=2029711 --- Comment #3 from Damien Le Moal <damien.lemoal@xxxxxxx> --- (In reply to Neal Gompa from comment #2) > > Requires: pkgconfig > > This is not needed, as RPM will autogenerate the dependency > > > Requires: gtk3 > > This is not needed, as RPM will autogenerate the dependency > > > rm -rf ${RPM_BUILD_ROOT} > > mkdir -p ${RPM_BUILD_ROOT} > > This is not needed as this should be done automatically now. > > > make install PREFIX=%{_prefix} DESTDIR=${RPM_BUILD_ROOT} > > This should be "%make_install PREFIX=%{_prefix}" Hi Neal, Thanks for the review. I updated the spec file (and source rpm) as you suggested. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2029711 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
